[Actionable Observability] rules page read permissions & snoozed status & no data screen #128108

mgiota · 2022-03-18T21:56:41Z

Fixes #123585 -> must have for 8.2
Fixes #127434 -> must have for 8.2 (this depends on #123585, so it had to be pushed in this open PR)
Fixes #127583 -> nice to have (this depends on #123585, so it had to be pushed in this open PR)

Acceptance criteria

Allowed rule operations for users with read permissions #123585
- users should be able to view the observability rules
- users should not be able to edit a rule
- users should not be able to delete a rule
- users should not be able to create a new rule
- users should not be able to change the status of the rule
Add Snoozed status in the rules table Status column #127434
- ~~Snoozed permanently~~Snoozed indefinitely status is added to the status column
No data screen for rules page #127583

Before

After
Authorized user

Unauthorized user

cc @katrin-freihofner

…ge_read_permissions

mgiota · 2022-03-21T07:45:21Z

@elasticmachine merge upstream

x-pack/plugins/observability/public/pages/rules/components/status_context.tsx

mgiota · 2022-03-22T07:39:27Z

@XavierM @katrin-freihofner I updated Snoozed label to Snoozed permanently as per our discussion

@XavierM Can you send me the ticket of your team with the new snooze api?

cc @vinaychandrasekhar

mgiota · 2022-03-22T20:51:08Z

@elasticmachine merge upstream

XavierM · 2022-03-22T21:19:45Z

@XavierM @katrin-freihofner I updated Snoozed label to Snoozed permanently as per our discussion

@XavierM Can you send me the ticket of your team with the new snooze api?

cc @vinaychandrasekhar

That's our PR #128214 and please do not hate me but it looks like that we call it snooze indefinitely

mgiota · 2022-03-22T21:53:35Z

it looks like that we call it snooze indefinitely

@XavierM I renamed to indefinitely. Thanks for the link to your PR. I will keep an eye on it. If it is merged in time, I might be able to use the new snooze api.

mgiota · 2022-03-22T22:21:03Z

I just had a look at your PR. If you expose the x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx component in the start method https://github.com/elastic/kibana/blob/main/x-pack/plugins/triggers_actions_ui/public/plugin.ts#L190, I could easily reuse it.

I can expose your component, once your PR is merged. I don't want to push for it, since we didn't plan to deliver the new snooze api in the o11y rules page anyway. But if you make it in time, I can squeeze this in o11y as well for 8.2.

cc @katrin-freihofner @vinaychandrasekhar

…y results

…ation to the use_fetch_rules hook

fkanout · 2022-03-23T12:30:31Z

@mgiota, I don't know exactly the expected behavior, so I will share this with you
I created a user with the next role privileges (APM all and read for the others):

However, when I went to the rules pages trying to create an APM Error Count rule, I'm getting the next error

And I can click save, but I will have the error rule status.
Is that normal? do I need more privileges to be able to create an APM rule?

XavierM · 2022-03-23T12:46:14Z

I just had a look at your PR. If you expose the x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx component in the start method https://github.com/elastic/kibana/blob/main/x-pack/plugins/triggers_actions_ui/public/plugin.ts#L190, I could easily reuse it.

I can expose your component, once your PR is merged. I don't want to push for it, since we didn't plan to deliver the new snooze api in the o11y rules page anyway. But if you make it in time, I can squeeze this in o11y as well for 8.2.

cc @katrin-freihofner @vinaychandrasekhar

That's the plan for 8.3, for 8.2 we were just making it internal. I do think that we should also focus our time to get the rules table re-usable between plugins. Therefore a lot of feature will come available to you for free. It is more work at the beginning but we will be more aligned in the long run.

XavierM · 2022-03-23T12:49:47Z

@fkanout can you try to replace this

by Actions and Connectors All All?
I think you need to be able to have access to Actions and Connectors in the same space than your APM privileges

fkanout · 2022-03-23T13:12:15Z

@XavierM, I updated the role privileges as suggested, the issue is still there.

But I realized something interesting, and I'm not sure if it's related to this PR. It seems there are ONLY 2 rule types from APM throwing this error: Failed transaction rate threshold , and Latency threshold.

cc @mgiota

fkanout · 2022-03-23T13:16:07Z

@XavierM, I updated the role privileges as suggested, the issue is still there.

But I realized something interesting, and I'm not sure if it's related to this PR. There are ONLY 2 rule types from APM >throwing this error: Failed transaction rate threshold , and Latency threshold.

cc @mgiota

FYI, I tried the same thing with the same user (apm-all), but on Kibana main branch, the issue is there too (if it's an issue and not missing privileges). 🤔

fkanout · 2022-03-23T13:49:34Z

x-pack/plugins/observability/public/pages/rules/components/status_context.tsx

-  const currentStatus = item.enabled ? RuleStatus.enabled : RuleStatus.disabled;
+  let currentStatus: RuleStatus;
+  if (item.enabled) {
+    currentStatus = item.muteAll ? RuleStatus.snoozed : RuleStatus.enabled;


Is it possible to have a rule enabled and muted at the same time?

I assume snoozed == muteAll, right? The API that provides the item is using muteAll

@fkanout Yep we are using muteAll for the snoozed (indefinitely) state. And yes a rule can be enabled and muted at the same time. I had similar questions here #123580 (comment) and we ended up with @katrin-freihofner on following:

If it is only enabled the Enabled state is shown in the UI

If it is snoozed, then the Snoozed indefinitely state is shown in the UI, and yep it is enabled as well.

To unmute/unsnooze user needs to select enabled (behind the scenes it enables and unmutes the rule)

@mgiota, excellent explanation, thanks!
snoozed + enabled will keep the rule but it will not generate alerts?

mgiota · 2022-03-23T14:27:10Z

@XavierM, I updated the role privileges as suggested, the issue is still there.
But I realized something interesting, and I'm not sure if it's related to this PR. There are ONLY 2 rule types from APM >throwing this error: Failed transaction rate threshold , and Latency threshold.
cc @mgiota

FYI, I tried the same thing with the same user (apm-all), but on Kibana main branch, the issue is there too (if it's an issue and not missing privileges). 🤔

@fkanout For apm it looks like you need to have these predefined roles { "names": ["apm-*", "logs-apm*", "metrics-apm*", "traces-apm*"], "privileges": ["read", "view_index_metadata"] } as described here #90806. I will try it now as well

mgiota · 2022-03-23T14:41:01Z

@fkanout I can confirm that everything works fine if you define following according to the predefined roles mentioned here #90806

Without about mentioned predefined roles I get the error you mentioned both in the Stack Management rules page and the o11y rules page. So it is no problem with the code, but as you correctly guessed missing privileges and indices in the custom role configuration.

mgiota · 2022-03-23T14:50:59Z

I do think that we should also focus our time to get the rules table re-usable between plugins. Therefore a lot of feature will come available to you for free. It is more work at the beginning but we will be more aligned in the long run.

@XavierM I totally agree. The two hooks I already created (use_fetch_rules and use_load_rule_types) are moving towards this direction.

I already have a plan in my mind. After feature freeze and once we prioritize with the team, I can start working towards this direction.

XavierM

Approved changes in triggersActionUi plugin

fkanout

LGTM, just need to green the CI.

mgiota · 2022-03-24T08:24:57Z

@elasticmachine merge upstream

kibana-ci · 2022-03-24T09:51:02Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	380	383	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`triggersActionsUi`	273	277	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	415.9KB	419.4KB	+3.5KB
`triggersActionsUi`	663.2KB	663.2KB	+7.0B
total			+3.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	90.2KB	90.2KB	+52.0B
`triggersActionsUi`	96.6KB	96.7KB	+177.0B
total			+229.0B

Unknown metric groups

API count

id	before	after	diff
`triggersActionsUi`	285	289	+4

History

💔 Build #33317 failed d3e9162
💚 Build #32955 succeeded b98f947
💚 Build #32848 succeeded 4b9937e
💔 Build #32624 failed f71fca7
💔 Build #32612 failed 1699116

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

mgiota added 3 commits March 18, 2022 22:17

users with read permissions can not edit/delete/create rules

3a07e12

users with read permissions can not change the status

32ff27d

Merge branch 'main' of github.com:elastic/kibana into 123585_rules_pa…

22d99c8

…ge_read_permissions

mgiota self-assigned this Mar 21, 2022

mgiota marked this pull request as ready for review March 21, 2022 07:40

mgiota added v8.2.0 Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Mar 21, 2022

Merge branch 'main' into 123585_rules_page_read_permissions

dbeef85

mgiota changed the title ~~123585 rules page read permissions~~ [Actionable Observability] rules page read permissions Mar 21, 2022

mgiota added the release_note:skip Skip the PR/issue when compiling release notes label Mar 21, 2022

mgiota requested a review from fkanout March 21, 2022 08:02

mgiota added 5 commits March 21, 2022 09:53

clean up unused code

882de2e

localization for change status aria label

20607d6

remove console log

237cb23

add muted status

2d51427

rename to snoozed

ca868ba

mgiota requested a review from a team as a code owner March 21, 2022 11:17

mgiota changed the title ~~[Actionable Observability] rules page read permissions~~ [Actionable Observability] rules page read permissions & snoozed status Mar 21, 2022

remove unused imports

d87bd1c

XavierM reviewed Mar 21, 2022

View reviewed changes

x-pack/plugins/observability/public/pages/rules/components/status_context.tsx Show resolved Hide resolved

rename snoozed to snoozed permanently

ab76864

mgiota requested a review from XavierM March 22, 2022 07:36

mgiota added 2 commits March 22, 2022 10:11

localize statuses

316a086

implement no data and no permission screen

1699116

mgiota changed the title ~~[Actionable Observability] rules page read permissions & snoozed status~~ [Actionable Observability] rules page read permissions & snoozed status & no data screen Mar 22, 2022

mgiota added 2 commits March 22, 2022 14:36

fix prompt filenames

f71fca7

fix i18n error

4685334

mgiota mentioned this pull request Mar 22, 2022

[RAM] Add aggs to know how many rules are snoozed #128212

Merged

1 task

change permanently to indefinitely

4b9937e

mgiota added 3 commits March 23, 2022 09:47

do not show noData screen when filters are applied and don't match an…

7ddd805

…y results

add centered spinner on initial load

bd5a873

move currrent functionality from triggers_actions_ui related to pagin…

b98f947

…ation to the use_fetch_rules hook

mgiota force-pushed the 123585_rules_page_read_permissions branch from de225e2 to b98f947 Compare March 23, 2022 09:54

mgiota mentioned this pull request Mar 23, 2022

[Actionable Observability] filter by o11y rule types #128370

Merged

fkanout reviewed Mar 23, 2022

View reviewed changes

mgiota requested a review from fkanout March 23, 2022 14:51

XavierM approved these changes Mar 23, 2022

View reviewed changes

disable status column if license is not enabled

d3e9162

fkanout approved these changes Mar 24, 2022

View reviewed changes

Merge branch 'main' into 123585_rules_page_read_permissions

e4c11f4

mgiota enabled auto-merge (squash) March 24, 2022 09:16

mgiota merged commit 55d7476 into elastic:main Mar 24, 2022

mgiota added the backport:skip This commit does not require backporting label Mar 28, 2022

mgiota deleted the 123585_rules_page_read_permissions branch May 10, 2022 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Actionable Observability] rules page read permissions & snoozed status & no data screen #128108

[Actionable Observability] rules page read permissions & snoozed status & no data screen #128108

mgiota commented Mar 18, 2022 •

edited

Loading

mgiota commented Mar 21, 2022

mgiota commented Mar 22, 2022

mgiota commented Mar 22, 2022

XavierM commented Mar 22, 2022 •

edited

Loading

mgiota commented Mar 22, 2022 •

edited

Loading

mgiota commented Mar 22, 2022 •

edited

Loading

fkanout commented Mar 23, 2022

XavierM commented Mar 23, 2022

XavierM commented Mar 23, 2022 •

edited

Loading

fkanout commented Mar 23, 2022 •

edited

Loading

fkanout commented Mar 23, 2022 •

edited

Loading

fkanout Mar 23, 2022

mgiota Mar 23, 2022

fkanout Mar 24, 2022

mgiota commented Mar 23, 2022

mgiota commented Mar 23, 2022 •

edited

Loading

mgiota commented Mar 23, 2022

XavierM left a comment

fkanout left a comment

mgiota commented Mar 24, 2022

kibana-ci commented Mar 24, 2022

API count

[Actionable Observability] rules page read permissions & snoozed status & no data screen #128108

[Actionable Observability] rules page read permissions & snoozed status & no data screen #128108

Conversation

mgiota commented Mar 18, 2022 • edited Loading

Acceptance criteria

mgiota commented Mar 21, 2022

mgiota commented Mar 22, 2022

mgiota commented Mar 22, 2022

XavierM commented Mar 22, 2022 • edited Loading

mgiota commented Mar 22, 2022 • edited Loading

mgiota commented Mar 22, 2022 • edited Loading

fkanout commented Mar 23, 2022

XavierM commented Mar 23, 2022

XavierM commented Mar 23, 2022 • edited Loading

fkanout commented Mar 23, 2022 • edited Loading

fkanout commented Mar 23, 2022 • edited Loading

fkanout Mar 23, 2022

Choose a reason for hiding this comment

mgiota Mar 23, 2022

Choose a reason for hiding this comment

fkanout Mar 24, 2022

Choose a reason for hiding this comment

mgiota commented Mar 23, 2022

mgiota commented Mar 23, 2022 • edited Loading

mgiota commented Mar 23, 2022

XavierM left a comment

Choose a reason for hiding this comment

fkanout left a comment

Choose a reason for hiding this comment

mgiota commented Mar 24, 2022

kibana-ci commented Mar 24, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

mgiota commented Mar 18, 2022 •

edited

Loading

XavierM commented Mar 22, 2022 •

edited

Loading

mgiota commented Mar 22, 2022 •

edited

Loading

mgiota commented Mar 22, 2022 •

edited

Loading

XavierM commented Mar 23, 2022 •

edited

Loading

fkanout commented Mar 23, 2022 •

edited

Loading

fkanout commented Mar 23, 2022 •

edited

Loading

mgiota commented Mar 23, 2022 •

edited

Loading